Skip to content

fix: expand and collapse whole folder groups #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2023

Conversation

Danie-1
Copy link
Contributor

@Danie-1 Danie-1 commented Aug 16, 2023

Currently when opening folder groups, the folder icon and arrow indicators don't change correctly.
Current behaviour:
image
With this fix:
image

@alex-courtis
Copy link
Member

Regression since #2100

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for addressing this one!

  • replace next
  • bonus points: replace other usages of next

@alex-courtis
Copy link
Member

When removing the last file in a grouped or ungrouped open folder it still shows as opened.

No need to address that; it's an edge case that will likely be difficult to resolve and will have a high blast radius.

@Danie-1
Copy link
Contributor Author

Danie-1 commented Aug 20, 2023

I had a brief look at earning the bonus points but it looked like it would take me a little bit of time to figure what would be a suitable variable name to replace it (in some of the places). I can open a pull request for it at some point if noone else does it first.

@Danie-1
Copy link
Contributor Author

Danie-1 commented Aug 20, 2023

Also I was expecting there might still be some edge cases this didn't handle but I was thinking maybe some of those edge cases might be caused by a similar issue to this one, where the state of each node in a group should be changed rather than a single node (but I'm not at all certain about that because I haven't found buggy edge cases or looked at the code for stuff).

@alex-courtis
Copy link
Member

I had a brief look at earning the bonus points but it looked like it would take me a little bit of time to figure what would be a suitable variable name to replace it (in some of the places). I can open a pull request for it at some point if noone else does it first.

No worries, well out of scope.

@alex-courtis
Copy link
Member

Also I was expecting there might still be some edge cases this didn't handle but I was thinking maybe some of those edge cases might be caused by a similar issue to this one, where the state of each node in a group should be changed rather than a single node (but I'm not at all certain about that because I haven't found buggy edge cases or looked at the code for stuff).

That's fine. Folder/grouping is complex and we can only fix what we know about.

@alex-courtis alex-courtis merged commit 0074120 into nvim-tree:master Aug 26, 2023
alex-courtis added a commit that referenced this pull request Jul 21, 2024
refactor(#2380): multi instance nvim-tree.marks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants